cmd/snap, daemon, overlord/snapstate: tests and fixes for "snap refresh" of a classic snap #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh" of a classic snap
mvo5
approved these changes
Jan 11, 2017
| @@ -520,6 +520,11 @@ func Update(st *state.State, name, channel string, revision snap.Revision, userI | |||
| channel = snapst.Channel | |||
| } | |||
|
|
|||
| if !flags.JailMode { | |||
There was a problem hiding this comment.
Do we need a test for this as well?
pedronis
reviewed
Jan 11, 2017
| @@ -520,6 +520,11 @@ func Update(st *state.State, name, channel string, revision snap.Revision, userI | |||
| channel = snapst.Channel | |||
| } | |||
|
|
|||
| if !flags.JailMode { | |||
There was a problem hiding this comment.
is this tested? also seems obscure tbh, it will not be marked classic but it will be marked jailmode
| c.Assert(err, IsNil) | ||
| c.Check(snapsup.Flags.Classic, Equals, true) |
There was a problem hiding this comment.
sort of feel a test where we actually run the tasks and look also at final snapstate would be even better
There was a problem hiding this comment.
to be clear I think such a test would show the problem @mvo5 hit, these were passing anyway
pedronis
reviewed
Jan 11, 2017
| @@ -520,6 +520,11 @@ func Update(st *state.State, name, channel string, revision snap.Revision, userI | |||
| channel = snapst.Channel | |||
| } | |||
|
|
|||
| if !(flags.JailMode || flags.DevMode) { | |||
| // adding a mode flag means add them all | |||
There was a problem hiding this comment.
I don't understand the comment, the code seems ok without
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.